Add common spec and run validation against it #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not allow to configure format for @timestamp.
* fix: timestamp format to ISO8601 * add tests for spec validation implements elastic#19
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
simitt
changed the title
axw
requested changes
Jan 11, 2021
logger_test.go
Outdated
Comment on lines
72
to
75
| if field.Required { // all required fields must be present in the log line | ||
| require.Contains(t, tw.m, name) | ||
| require.NotNil(t, tw.m[name]) | ||
| } |
There was a problem hiding this comment.
This will never fail, because we're ranging over tw.m rather than spec.V1.Fields. We should swap that around.
There was a problem hiding this comment.
good catch - updated
axw
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR copies the common spec for ECS loggers and runs validations for the fields that are already supported.
The spec itself is just manually copied over, as according to https://github.com/elastic/observability-robots/issues/313 the spec should automatically be synced when changed.
While on it, a bug was found in the
timestampformat, where the timestamp can be changed from the defaultISO8601format to any other format. With this fix the timestamp will always beISO8601for the ECS formatter.closes #19