NLog v5.2.5 #510
Open
NLog v5.2.5 #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Mpdreamz
previously approved these changes
May 28, 2025
|
run docs-build |
|
@Mpdreamz Fixed merge-conflicts, and updated unit-test to not rely on obsolete API. |
Mpdreamz
previously approved these changes
Jun 3, 2025
|
run docs-build |
|
Little confused about how to handle the failing unit-test Guess I just have to wait until build-server-gods are merciful. |
|
Think I found the cause of the failing unit-tests. NLog doesn't like that one re-assigns Unit test are green for me now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe the next major-version could also include NLog upgrade?