action: update specs #251
Merged
action: update specs #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
added
automation
Team:Automation
v1v
commented
Feb 7, 2023
reakaleek
approved these changes
Feb 7, 2023
| automerge: false | ||
| labels: | ||
| - dependencies | ||
| title: 'synchronize ecs-logging spec' |
There was a problem hiding this comment.
Is this actually working for you? 😲
There was a problem hiding this comment.
I'm using dry-run in my local, let me try with my fork
There was a problem hiding this comment.
v1v#1 nop!
But by changing the target name:
targets:
spec.json-update:
- name: Update spec.json
+ name: 'synchronize ecs-logging spec'
kind: file
sourceid: spec.json
scmid: githubConfigThere was a problem hiding this comment.
Interesting. Thanks for checking.
There was a problem hiding this comment.
Interesting. Thanks for checking.
There was a problem hiding this comment.
Interesting. Thanks for checking.
v1v
commented
Feb 7, 2023
v1v
commented
Feb 7, 2023
Mpdreamz
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use GitHub actions in addition to the
updateclito bump the json schemas created inecs-logging.It runs on a daily basis and create a Pull Request if new changes exist.
Test
#250 was created with this setup
Tasks
Create PRs with the description pointing to the original change in the ecs-logging, similarly done in #235