Skip to content

Update conf.yaml for 7.16 #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 20, 2021
Merged

Update conf.yaml for 7.16 #2249

merged 15 commits into from
Oct 20, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 18, 2021

This PR updates the conf.yaml to build from 7.16 branches instead of 7.x branches (with the exception of the client docs, which I'm presuming will continue to use 7.x).

@lcawl lcawl requested a review from gtback October 18, 2021 21:50
gtback
gtback approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bmorelli25
bmorelli25 reviewed Oct 19, 2021
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add 7.16 for the APM Overview and APM Server Reference. I think things will 💣🔥 otherwise. Lines 1124 & 1140:

https://github.com/elastic/docs/pull/2249/files#diff-9925a85f7cc77717016f5dc21db102f95ff353476bf96849dff5d65cb94ef02dR1124

https://github.com/elastic/docs/pull/2249/files#diff-9925a85f7cc77717016f5dc21db102f95ff353476bf96849dff5d65cb94ef02dR1140

@lcawl
Copy link
Contributor Author

lcawl commented Oct 19, 2021

Can you please add 7.16 for the APM Overview and APM Server Reference...

Thanks! Done in 185852d

chriscressman
chriscressman approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@chriscressman chriscressman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enterprise Search ✔️

@lcawl
Copy link
Contributor Author

lcawl commented Oct 20, 2021

@elasticmachine run elasticsearch-ci/docs

@lcawl lcawl marked this pull request as ready for review October 20, 2021 16:58
@lcawl
Copy link
Contributor Author

lcawl commented Oct 20, 2021

@elasticmachine update branch

@lcawl
Copy link
Contributor Author

lcawl commented Oct 20, 2021

@elasticmachine run elasticsearch-ci/docs

@gtback gtback merged commit 23fd782 into elastic:master Oct 20, 2021
@gtback
Copy link
Member

gtback commented Oct 20, 2021

Admin-merging. We can handle the failing Cloud builds separately.

@lcawl lcawl deleted the 716-7x-2 branch October 20, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 left review comments

@chriscressman chriscressman chriscressman approved these changes

@gtback gtback gtback approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lcawl @gtback @chriscressman @bmorelli25