Skip to content

Change ECS chunking level #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Sep 30, 2020

Updating the ECS book chunking config from 1 to 2. This change will enable adding additional usage sub-sections per fieldset in the ECS field reference.

Example:

Screen Shot 2020-09-30 at 1 21 20 PM

The full details of these ECS documentation changes are captured in elastic/ecs#943.

Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine and does exactly what it claims to do 😁 .

I'll note that in a lot of the docs, writers are moving to longer pages, to make it easier on developers to CTRL-F to find content on a page. Additionally, the pages that currently hold the bulk of the information, like https://www.elastic.co/guide/en/ecs/current/ecs-as.html, are changing to become stubs like https://docs_1970.docs-preview.app.elstc.co/guide/en/ecs/current/ecs-as.html. At least we don't need to add redirects, but I think it's still a suboptimal user experience.

Finally, all of the "Field Reuse" pages have URLs like https://docs_1970.docs-preview.app.elstc.co/guide/en/ecs/current/_field_reuse_6.html. It might be good to update the IDs in the source files before merging this in. That will break existing anchors like https://www.elastic.co/guide/en/ecs/current/ecs-file.html#_field_reuse_6, but those will be changing anyway as this content gets moved onto a new page.

@ebeahan
Copy link
Member Author

ebeahan commented Oct 1, 2020

Thanks @gtback!

Looking at the preview, this isn't exactly what the ECS team wants either 😅 . I suspect that this preview was built before I merged elastic/ecs#989, which should prevent the large sweeping changes you've noted.

I'll re-run the docs build and verify the changes are as intended.

cc @webmat

@ebeahan
Copy link
Member Author

ebeahan commented Oct 1, 2020

@elasticmachine, run elasticsearch-ci/docs

@ebeahan
Copy link
Member Author

ebeahan commented Oct 1, 2020

master and 1.x are now correct in the docs preview, but I have some additional backporting for the other versions (including current/1.6) to perform.

@webmat
Copy link

webmat commented Oct 2, 2020

Quick question @gtback, is it possible for us to set the chunking per branch of the ECS docs?

Setting chunking to 2 should only be relevant to our next release, 1.7. Since the pages that require an adjustment in adding [discrete] are generated pages, we need to go modify different versions of the script over the years to make all past versions look right, at this new setting.

If instead we can easily force chunking to 1 in branches 1.0, 1.1, 1.2, 1.3, 1.4, 1.5 and 1.6 from here, I think that would be easier.

@gtback
Copy link
Member

gtback commented Oct 5, 2020

Hey @webmat. It's not currently possible to change chunking level per-branch. If it's important, I can look into what level of effort would be needed to add this ability.

An alternative would be to create a new book and move the current one to the "legacy" section, but then you lose some of the ability to switch between the "same" page in different versions, and we might have to choose a different URL. I'd say the cons of that approach probably outweigh the pros, but wanted to at least suggest it.

@webmat
Copy link

webmat commented Oct 5, 2020

Alright, thanks @gtback! We'll handle it on our side, then.

@ebeahan
Copy link
Member Author

ebeahan commented Oct 5, 2020

@elasticmachine, run elasticsearch-ci/docs

@ebeahan ebeahan merged commit a1e397a into elastic:master Oct 7, 2020
@ebeahan ebeahan deleted the change-ecs-chunking branch October 7, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants