Skip to content

Add anchor with hash of example #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Jan 29, 2020

This adds an <a> tag above every example listing that could
potentially have alternative languages with id set to the hash of the
example. This is useful for the folks writing the alternative language
examples so they can easily see the examples in context.

Closes #1709

This adds an `<a>` tag above every example listing that could
potentially have alternative languages with `id` set to the hash of the
example. This is useful for the folks writing the alternative language
examples so they can easilly see the examples in context.

Closes elastic#1709
@nik9000 nik9000 requested a review from olksdr January 29, 2020 22:48
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :shipit:

@philkra
Copy link
Contributor

philkra commented Jan 30, 2020

ping @picandocodigo

@nik9000 nik9000 merged commit c55b1a9 into elastic:master Jan 30, 2020
@Mpdreamz
Copy link
Member

Awesome thank you @nik9000 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an HTML anchor <a> with the digest of the code example
4 participants