Skip to content

Add anchor with hash of example - #1717

Merged
nik9000 merged 1 commit into
elastic:masterfrom
nik9000:alternative_hash
Jan 30, 2020
Merged

Add anchor with hash of example#1717
nik9000 merged 1 commit into
elastic:masterfrom
nik9000:alternative_hash

Conversation

@nik9000

@nik9000 nik9000 commented Jan 29, 2020

Copy link
Copy Markdown
Contributor

This adds an <a> tag above every example listing that could
potentially have alternative languages with id set to the hash of the
example. This is useful for the folks writing the alternative language
examples so they can easily see the examples in context.

Closes #1709

This adds an `<a>` tag above every example listing that could
potentially have alternative languages with `id` set to the hash of the
example. This is useful for the folks writing the alternative language
examples so they can easilly see the examples in context.

Closes elastic#1709
@nik9000
nik9000 requested a review from olksdr January 29, 2020 22:48

@olksdr olksdr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :shipit:

@philkra

philkra commented Jan 30, 2020

Copy link
Copy Markdown
Contributor

ping @picandocodigo

@nik9000
nik9000 merged commit c55b1a9 into elastic:master Jan 30, 2020
@Mpdreamz

Copy link
Copy Markdown
Member

Awesome thank you @nik9000 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an HTML anchor <a> with the digest of the code example

4 participants