Skip to content

Generalize links checking #614

Open
Open
@nik9000

Description

@nik9000

Right now we have code in the docs build that checks links from the docs to the docs and we have code that checks links from Kibana to the docs. The Kibana to the docs links checking code uses regexes to grab links from bits of Kibana's code. This seems brittle because Kibana might want to move things around or build links with string concatenations or, well, all kinds of stuff. I don't really care Kibana wants to build links.

I wonder if we'd be better off having build_docs.pl look for an executable file in every branch of every repo that it knows about and runs it to get a list of links. This'd rely on two things:

  1. Docker to resolve the dependencies that we need.
  2. Kibana to write a script to dump their own links.

I'm quite happy to install some node version in the docker image but I really would like the script to be quick so I don't think it should have to resolve dependencies itself. I'm not sure if that is a think Kibana would want to do, but it feels cleaner than the regexes we have now.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions