Skip to content

Handling previews for PRs against feature branches #1693

Open
@lcawl

Description

@lcawl

It seems that documentation previews are not generated for feature branches.

For example, in elastic/elasticsearch#50821 the elasticsearch-ci/docs check is successful but doesn't generate previews and the log says:

15:21:37 INFO:build_docs:No changes to push

There are in fact documentation changes in that PR, however, so it seems to me that check is providing misinformation.

I think we should make it clearer somehow that folks need to do their own documentation builds to verify changes in these types of PRs. For example, maybe it's simplest to just disable these checks entirely on the branches that can't generate docs (so they're not giving false success indicators). Or else enable correct testing for all branches.

Metadata

Metadata

Assignees

No one assigned

    Labels

    deferpreviewAbout the preview service canonically hosted on docs-preview.app.elstc.coteam-discuss

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions