Skip to content

[Security] Attack Discovery scheduling and saved discoveries #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

natasha-moore-elastic
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic commented Jul 3, 2025

Contributes to #1939 and #1941.
Documents the new Attack Discovery features:

  • Scheduling and notification
  • Viewing historical discoveries

Copy link

github-actions bot commented Jul 3, 2025

🔍 Preview links for changed docs

@natasha-moore-elastic natasha-moore-elastic added Serverless Improvements and changes to the Serverless Docs v9.1.0 labels Jul 3, 2025
@natasha-moore-elastic natasha-moore-elastic marked this pull request as ready for review July 3, 2025 12:46
@natasha-moore-elastic natasha-moore-elastic requested review from a team as code owners July 3, 2025 12:46
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question about preview/ga status

@@ -54,7 +47,7 @@ Attack Discovery is designed for use with alerts based on data that complies wit
The selected fields can now be analyzed the next time you run Attack Discovery.
:::

## Generate discoveries [attack-discovery-generate-discoveries]
## Generate discoveries manually[attack-discovery-generate-discoveries]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the following updates in this section; (sorry, GH won't let me comment on the specific lines because they are unchanged):

  1. Select an existing connector from the dropdown menu, or add a new one.
  • In the new design, the user must first click the gear icon next to the Generate button to access the connector dropdown. Note: This is different than the Connector filter (located next to the Status filter) on the main page.

  • The screenshot in this section may be updated to illustrate the updated "empty" state, for example:

attack_discovery_empty_state

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the What information does each discovery include? section (sorry, GH won't let me comment on the unchanged line numbers), consider updating the following image:

:::{image} /solutions/images/security-attck-disc-example-disc.png
:alt: Attack Discovery detail view
:::

to the following (or a similar) refreshed screenshot, which includes the new status and sharing indicators:

latest_example


### Change a discovery's status

You can set a discovery's status to indicate that it's under active investigation or that it's been resolved. To do this, click **Take action**, then select **Mark as acknowledged** or **Mark as closed**.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attack discoveries have a new (introduced in 8.19.0 / 9.1.0) workflow status, illustrated by the screenshot below:

workflow_status

This workflow status (of the discovery itself), is separate from the alerts associated with the attack discovery.

Consider documenting the option for users to (optionally) update the workflow status of the alerts associated an attack discovery, as illustrated by the following screenshot, which appears when user click the Mark as open | acknowledged | closed Take action menu items:

update_alerts

The updated alerts associated with the attack discovery are illustrated by the screenshot below:

updated_alerts


* **Visibility**: Use this filter to, for example, show only shared discoveries.

* **Status**: Filter discoveries by their current status.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider creating a new Sharing Attack discoveries section to document this feature introduced in 8.19.0 / 9.1.0, which is illustrated by the screenshot below:

sharing_status

Consider speaking to the following nuances:

  • Manually generated discoveries are initially Not shared
  • Scheduled discoveries are (automatically) Shared
  • Once shared, the visibility of shared discoveries cannot be changed, as illustrated by the screenshot below:

shared_cannot_be_changed


To create a new schedule:

1. Click the gear icon to open the settings menu, then select **Schedule**.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, this flow will be changed soon. Design team currently finalising mockups where "Schedule" tab will be opened by clicking on a separate button within the main page.

@@ -54,7 +47,7 @@ Attack Discovery is designed for use with alerts based on data that complies wit
The selected fields can now be analyzed the next time you run Attack Discovery.
:::

## Generate discoveries [attack-discovery-generate-discoveries]
## Generate discoveries manually[attack-discovery-generate-discoveries]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to add a Index privileges section describing minimum requirements for the user to be able to interact with the new attack discovery alerts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Serverless Improvements and changes to the Serverless Docs v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants