Add navigational search component #2398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
approved these changes
Dec 23, 2025
cotti
approved these changes
Dec 23, 2025
Member
|
Do we want to move the divider above the content dropdown selector |
- Move ALPHA badge, feedback link, and keyboard shortcuts to footer - Remove SearchDropdownHeader component usage - Add inline KeyboardKey, KeyboardIcon, KeyboardShortcutItem components - Consolidate footer styling in NavigationSearch component
- Update search result titles to bold font-weight - Change mark highlights background to backgroundLightPrimary - Update empty state message and styling to match placeholder - Improve scroll behavior (scrollIntoView block: end) - Increase max height to 454px and add border-radius - Enhance hover and selection states
- Replace EuiIcon with custom SVG search icon - Simplify ⌘K shortcut display (remove border/background, match placeholder style) - Update keyboard shortcuts pills styling: - Background: backgroundBaseHighlighted - Border: 1px solid borderBasePlain - Text color: textSubdued - Font-size: 11px, line-height: 16px - Different padding for icon vs text shortcuts - Adjust input padding to prevent text overlap with shortcut - Remove search-or-ask-ai from header
- Remove wrapper div around search-or-ask-ai component - Move padding-top to nav-tree container (pt-6) - Add EuiHorizontalRule-style separator below search component
- Change padding vertical from euiTheme.size.s (8px) to calc(euiTheme.size.s + 2px) (10px) - Keep horizontal padding at euiTheme.size.m (12px)
itsalexcm
force-pushed
the
feature/navigational-search
branch
from
25e64aa to
1ae854c
Compare
- Maintain keyboard-selected item highlighted even when mouse hovers over other items - Keep 'Jump to' indicator visible for keyboard-selected items during hover - Preserve selection styles priority: selected state overrides hover styles - Reset keyboard selection when user clicks on an item
- Remove complex keyboard selection preservation logic - Show 'Jump to' indicator for all selected items (keyboard or mouse) - Disable hover styles when navigating with keyboard - Simplify mouse interaction: hover changes selection normally - First element remains selected by default when results open
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
...ocumentation.Site/Assets/web-components/SearchOrAskAi/NavigationSearch/SearchResultsList.tsx
Fixed
Show fixed
Hide fixed
Contributor
|
I’m not sure why the assembler-preview is failing, so I’ll defer to those more familiar with it. Craft.mov |
Contributor
|
@itsalexcm The PR branch was a bit behind main. The new assembler preview depends on new declarations in a configuration file, so that's why it was failing. Merging main seems to have done the trick! |
Contributor
|
Thanks a lot, @cotti! Happy to keep learning new stuff every day. |
Member
The ASK AI button is visible in the assembler builder |
Contributor
|
@Mpdreamz couldn't reproduce it here... 
|
Member
|
Cant reproduce it either any longer LGTM Slight issue when rendering for mobile (pre-existing on main its the dropdown thats covered by the header). 
command+K doesn't work for me, might be my use of https://github.com/asmvik/skhd |
Member
Author
|
Fixed and looks like this now: |
Mpdreamz
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cursorful-video-1766478402775.mp4