-
Notifications
You must be signed in to change notification settings - Fork 34
Add PR label blockers to changelog creation #2350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lcawl
wants to merge
20
commits into
main
Choose a base branch
from
changelog-prs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Preview links for changed docs |
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…ect' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Contributor
|
This part looks good taking into account #2407's fixes; once it is merged here, we can merge this too IMO. |
Co-authored-by: Felipe Cotti <felipe.cotti@elastic.co>
…null' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
This was referenced Jan 5, 2026
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
docs-builder changelog addcommand to be able to create multiple changelog files if you provide multiple PRs in the--prsoption. This makes it easier to address situations where we've missed changelogs for multiple PRs.It also adds logic to block the creation of a changelog in the presence of chosen PR labels. This enables us to handle the situation where PRs have
non-issueorrelease_notes:skipor any label of their choosing.It also enables us to handle the situation where changelogs are not desired for specific combinations of product and label (e.g.cloud-serverlessandILM).[Edit] Upon further reflection, I think there are two circumstances: PR labels that block changelog creation and changelog areas that block inclusion in the docs (for a specific set of release notes). This PR only covers the first case. I've renamed the yaml entry to "add_blockers" so we can do a "render_blockers" in a subsequent PR (#2426).
Examples
If you have a changelog configuration file (
changelog.yml) like this, which enables the command to derive the areas and types from PR labels:Create changelogs for multiple PRs at once:
The command successfully creates three changelogs.
If you then update the
changelog.ymlconfiguration file to includeadd_blockers, for example:NOTE: The implementation supports two formats:
elasticsearch: - ">non-issue"elasticsearch, cloud-serverless: - ">non-issue"The comma-separated format expands to individual entries during YAML deserialization, so both formats work identically.
Then the same
docs-builder changelog addcommand returns the following messages:Additional examples of area mappings can be found in:
Changes
Summary
ChangelogCommand.csto accept--prsas a string arrayChangelogInputto usePrs(string array) instead ofPr(string)ChangelogServiceto process multiple PRsAddBlockersconfiguration toChangelogConfigurationcloud-serverlesswith ILM label)Prsinstead ofPradd_blockers.changelog.yml.examplewithadd_blockersconfiguration examplesdocs/contribute/changelog.mdto document the--prsoption and label blocking feature--prupdated to--prsAll tests pass and the code builds successfully. The implementation follows the existing codebase patterns and maintains backward compatibility by supporting single PR processing when only one PR is provided.
Generative AI disclosure
Tool(s) and model(s) used: composer-1 agent