Skip to content

Patch CrossLinkFetcher with Diagnostics Collector #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cotti
Copy link
Contributor

@cotti cotti commented Aug 18, 2025

Following the RCA for the downtime on August 16th, it was identified that docs-assembler did not register an error in the workflow, which was allowed to proceed and led to the docs website data being deleted.

This PR injects a DiagnosticsCollector and ensures code paths that throw an exception during data fetches register an error.

@cotti cotti self-assigned this Aug 18, 2025
@cotti cotti requested a review from a team as a code owner August 18, 2025 06:09
@cotti cotti added the bug label Aug 18, 2025
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is no longer needed after our catch all uncaught exception fix. Throwing exceptions only is sufficient here and we want it to halt the program if we can't resolve the link files.

@Mpdreamz Mpdreamz closed this Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants