Skip to content

Add handling for speculative matches in content source logic #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented May 21, 2025

This will flag version branches as a speculative match ensuring we'll onboard new version branches before they are actively marked as current / next.

If a current branch is already a version branch we will only build new version branches speculatively.

This also ensures new repositories will speculatively build for main / master or version branches.

This allows repositories to

  • branch their next current (e.g 9.1) branch.
    • We will speculative build and publish the links.json from 9.1.
  • They can update the current branch in assembler.yml to 9.1 now at anytime because a links.json will have been published for it.

Otherwise we can never pull an update to assembler.yml because that would break the link resolvers trying to find the links.json for the current branch.

This also ensures new repositories can onboard their main and master branches without touching assembler.yml.

This will flag version branches as a speculative match ensuring we'll onboard new version branches before they are actively marked as current / next.

If a current branch is already a version branch we will only build new version branches speculatively.

This also ensures new repositories will speculatively build for `main` / `master` or version branches.
@Mpdreamz Mpdreamz merged commit d00a252 into main May 21, 2025
16 checks passed
@Mpdreamz Mpdreamz deleted the feature/speculative-match-for-builds branch May 21, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants