Skip to content

Throw warning when applies_to is empty #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 20, 2025
Merged

Conversation

theletterf
Copy link
Contributor

Fixes #609 (and updates the docs) by returning a warning and null for the ApplicableTo record if the applies_to frontmatter value is null or has spaces. This leaves the all behavior as is.

@theletterf theletterf requested a review from a team as a code owner May 12, 2025 08:45
@theletterf theletterf self-assigned this May 12, 2025
@theletterf theletterf mentioned this pull request May 12, 2025
3 tasks
@theletterf
Copy link
Contributor Author

@reakaleek Build's green!

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Small semantic change but any breakages will be born out of unintentionally defaulting to all

@Mpdreamz Mpdreamz merged commit 2ffb0de into main May 20, 2025
14 checks passed
@Mpdreamz Mpdreamz deleted the applies_to-validate-empty branch May 20, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

empty applies_to tag strangeness
2 participants