Support cross-repository redirects and specialized anchor scenarios #1227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for cross‐repository redirects and enhanced anchor handling in Markdown links.
- Updated HtmxLinkInlineRenderer to differentiate between cross links and HTTP links.
- Refactored CrossLinkResolver to improve redirect resolution and error reporting.
- Enhanced URI validation in DocumentationSet and updated documentation for redirects.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Elastic.Markdown/Myst/Renderers/HtmxLinkInlineRenderer.cs | Introduces new flags (isCrossLink, isHttpLink) and refines hx attribute assignment based on link types. |
| src/Elastic.Markdown/Links/CrossLinks/CrossLinkResolver.cs | Refactors redirect resolution logic with clearer variable naming and improved handling of anchors and lookup paths. |
| src/Elastic.Markdown/IO/DocumentationSet.cs | Adds URI validation for external redirect targets. |
| docs/contribute/redirects.md | Updates documentation with examples on cross-repository redirects and complex anchor scenarios. |
| 'item-a': 'yy' | ||
| - to: 'testing/redirects/third-page.md' | ||
| anchors: | ||
| 'item-b': |
There was a problem hiding this comment.
The anchor mapping for 'item-b' is empty, which could be unintentional. Confirm whether this is the desired behavior or if an explicit null/empty value should be specified for clarity.
Suggested change
| 'item-b': | |
| 'item-b': '!' |
Copilot uses AI. Check for mistakes.
Mpdreamz
requested changes
May 8, 2025
There was a problem hiding this comment.
Nice work!
A few nits about leniency. Can you also add more tests to https://github.com/elastic/docs-builder/blob/da90aa5d28612d4b9871462a4647cd41bb442494/tests/authoring/Inline/CrossLinksRedirects.fs ?
Mpdreamz
requested changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #670, #847
This MR introduces support for cross-repository redirects, and support for more complex anchor scenarios.