-
Notifications
You must be signed in to change notification settings - Fork 587
[FR] Add white space checking for KQL parse #3789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[FR] Add white space checking for KQL parse #3789
Conversation
This should probably be handled in the grammar instead |
The current grammar requires white space to be ignored. I think the way you are suggesting would require a refactor of both the grammar and the parsing to handle this. This would not only be a refactor/overhaul but in effect a full replacement as most of not all of the code would need to be updated compared to the relatively minor change I am suggesting. |
…ors-does-not-raise-error
…ors-does-not-raise-error
Enhancement - GuidelinesThese guidelines serve as a reminder set of considerations when addressing adding a feature to the code. Documentation and Context
Code Standards and Practices
Testing
Additional Checks
|
Related Issues
Resolves #2700
Summary
This addresses an issue where lark parses KQL queries without whitespace around certain tokens, where KQL does not.
E.g.
"Get-NetComputerSiteName" or "Get-NetLocalGroup"
vs"Get-NetComputerSiteName" or"Get-NetLocalGroup"
. Both of which parse via lark/ANTLR, but the second fails in Kibana.Some notes about alternative implementations:
This approach adds a post-processing step to the lark parsing to tell us where the and and or tokens are in the original string, then compare to see if those tokens locations have the appropriate spacing.
Note since this PR updates the KQL lib please make sure to update the KQL lib version appropriately.
Contributor checklist