[FR] Add --force flag to update-lock-versions #3693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-forte-elastic
added
enhancement
Mikaayenson
approved these changes
May 17, 2024
There was a problem hiding this comment.
This LGTM. IINM, for custom rule management, this is needed. We typically use build-release --update-version-lock but we decided not to add registry information. This allows us to still manage the version lock in CI without needing additional package registry info, and bypasses the interactive click confirmation.
traut
reviewed
May 17, 2024
| @@ -334,7 +334,8 @@ def prune_staging_area(target_stack_version: str, dry_run: bool, exception_list: | |||
|
|
|||
| @dev_group.command('update-lock-versions') | |||
| @click.argument('rule-ids', nargs=-1, required=False) | |||
| def update_lock_versions(rule_ids): | |||
| @click.option('--force', is_flag=True, help='Force update without confirmation') | |||
| def update_lock_versions(rule_ids: Tuple[str, ...], force: bool): | |||
There was a problem hiding this comment.
a nitpick: Tuple typehint is a bit too click-specific here, Sequence would be a better choice, if it is really not a list :)
There was a problem hiding this comment.
I agree that Sequence is more appropriate; however, we do not use Sequence in the code elsewhere for type hinting and we do use Tuple[str, ...]. For consistency, I think we should update to Sequence in a different PR where we can modify all of the relevant type hints all at once.
traut
approved these changes
May 17, 2024
protectionsmachine
pushed a commit
that referenced
this pull request
May 18, 2024
* Add --force flag to update-lock-versions * Add type hinting (cherry picked from commit 707ca32)
protectionsmachine
pushed a commit
that referenced
this pull request
May 18, 2024
* Add --force flag to update-lock-versions * Add type hinting (cherry picked from commit 707ca32)
protectionsmachine
pushed a commit
that referenced
this pull request
May 18, 2024
* Add --force flag to update-lock-versions * Add type hinting (cherry picked from commit 707ca32)
protectionsmachine
pushed a commit
that referenced
this pull request
May 18, 2024
* Add --force flag to update-lock-versions * Add type hinting (cherry picked from commit 707ca32)
protectionsmachine
pushed a commit
that referenced
this pull request
May 18, 2024
* Add --force flag to update-lock-versions * Add type hinting (cherry picked from commit 707ca32)
protectionsmachine
pushed a commit
that referenced
this pull request
May 18, 2024
* Add --force flag to update-lock-versions * Add type hinting (cherry picked from commit 707ca32)
protectionsmachine
pushed a commit
that referenced
this pull request
May 18, 2024
* Add --force flag to update-lock-versions * Add type hinting (cherry picked from commit 707ca32)
protectionsmachine
pushed a commit
that referenced
this pull request
May 18, 2024
* Add --force flag to update-lock-versions * Add type hinting (cherry picked from commit 707ca32)
protectionsmachine
pushed a commit
that referenced
this pull request
May 18, 2024
* Add --force flag to update-lock-versions * Add type hinting (cherry picked from commit 707ca32)
protectionsmachine
pushed a commit
that referenced
this pull request
May 18, 2024
* Add --force flag to update-lock-versions * Add type hinting (cherry picked from commit 707ca32)
protectionsmachine
pushed a commit
that referenced
this pull request
May 18, 2024
* Add --force flag to update-lock-versions * Add type hinting (cherry picked from commit 707ca32)
protectionsmachine
pushed a commit
that referenced
this pull request
May 18, 2024
* Add --force flag to update-lock-versions * Add type hinting (cherry picked from commit 707ca32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Summary
This PR adds a
--forceflag to lock versions to allow this command to be run in CI such that users can lock versions without needing to build a package.Testing
python -m detection_rules dev update-lock-versions --forceshould not have a confirm prompt.