-
Notifications
You must be signed in to change notification settings - Fork 587
[FR] Switch Default Behavior to not allow uppercase KQL Keywords #3574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eric-forte-elastic
merged 1 commit into
main
from
3573-fr-switch-default-behavior-to-not-allow-uppercase-kql-keywords
Apr 5, 2024
Merged
[FR] Switch Default Behavior to not allow uppercase KQL Keywords #3574
eric-forte-elastic
merged 1 commit into
main
from
3573-fr-switch-default-behavior-to-not-allow-uppercase-kql-keywords
Apr 5, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brokensound77
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mikaayenson
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
protectionsmachine
pushed a commit
that referenced
this pull request
Apr 5, 2024
(cherry picked from commit fbb6df5)
protectionsmachine
pushed a commit
that referenced
this pull request
Apr 5, 2024
(cherry picked from commit fbb6df5)
protectionsmachine
pushed a commit
that referenced
this pull request
Apr 5, 2024
(cherry picked from commit fbb6df5)
protectionsmachine
pushed a commit
that referenced
this pull request
Apr 5, 2024
(cherry picked from commit fbb6df5)
protectionsmachine
pushed a commit
that referenced
this pull request
Apr 5, 2024
(cherry picked from commit fbb6df5)
protectionsmachine
pushed a commit
that referenced
this pull request
Apr 5, 2024
(cherry picked from commit fbb6df5)
protectionsmachine
pushed a commit
that referenced
this pull request
Apr 5, 2024
(cherry picked from commit fbb6df5)
protectionsmachine
pushed a commit
that referenced
this pull request
Apr 5, 2024
(cherry picked from commit fbb6df5)
protectionsmachine
pushed a commit
that referenced
this pull request
Apr 5, 2024
(cherry picked from commit fbb6df5)
protectionsmachine
pushed a commit
that referenced
this pull request
Apr 5, 2024
(cherry picked from commit fbb6df5)
protectionsmachine
pushed a commit
that referenced
this pull request
Apr 5, 2024
(cherry picked from commit fbb6df5)
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#3573
Summary
We would like this uppercase conversion feature to be available for customers but internally we do not want it to be enabled by default.
See #3568 for more context. There should be 6 instances where we use kql.parse for creating/importing/testing/validation that we wish to revert. The only remaining case we want to keep is the unit test to make sure conversion functions as expected.
Testing
kuery
rule to use uppercase keywords.E.g. modify the query for
rules/integrations/gcp/defense_evasion_gcp_firewall_rule_created.toml
to:E.g.
python -m detection_rules view-rule rules/integrations/gcp/defense_evasion_gcp_firewall_rule_created.toml
python -m detection_rules create-rule
with capital keywordsE.g.
event.dataset:gcp.audit AND event.action:(*.compute.firewalls.insert OR google.appengine.*.Firewall.Create*Rule)
python -m detection_rules import-rules
E.g.
20240314T190337L.ndjson.txt
If all of these fail, then the behavior has been reverted successfully.