Skip to content

Add filebeat-* index pattern to rules based on system.auth dataset #3561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2024
Merged

Add filebeat-* index pattern to rules based on system.auth dataset #3561

merged 2 commits into from
Apr 3, 2024

Conversation

herrBez
Copy link
Contributor

@herrBez herrBez commented Apr 2, 2024

Issues

Summary

Add the filebeat-* index pattern to the rules that use the system.auth dataset. These rules already contain a "Filebeat setup" section, which is useless if the filebeat-* index is not considered during searches.

Contributor checklist

@w0rk3r w0rk3r requested a review from Aegrah April 2, 2024 14:19
Aegrah
Aegrah approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@Aegrah Aegrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, and 100% agreed. Thanks for the contribution, let's get this one merged.

@Aegrah Aegrah linked an issue Apr 3, 2024 that may be closed by this pull request
[Rule Tuning] Add filebeat-* index pattern to system.auth dataset rules #3559
Closed
@Aegrah Aegrah self-assigned this Apr 3, 2024
@herrBez
Copy link
Contributor Author

herrBez commented Apr 3, 2024

Great to hear it! Apparently, we need two appending reviewers to merge the PR :)

@Aegrah Aegrah requested a review from w0rk3r April 3, 2024 08:07
w0rk3r
w0rk3r approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@w0rk3r w0rk3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@Aegrah Aegrah merged commit 1536570 into elastic:main Apr 3, 2024
protectionsmachine pushed a commit that referenced this pull request Apr 3, 2024
@herrBez @github-actions
Add filebeat-* index pattern to rules based on system.auth dataset (#…
90490fb 
…3561)

Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>

(cherry picked from commit 1536570)
protectionsmachine pushed a commit that referenced this pull request Apr 3, 2024
@herrBez @github-actions
Add filebeat-* index pattern to rules based on system.auth dataset (#…
044835f 
…3561)

Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>

(cherry picked from commit 1536570)
protectionsmachine pushed a commit that referenced this pull request Apr 3, 2024
@herrBez @github-actions
Add filebeat-* index pattern to rules based on system.auth dataset (#…
022cc9c 
…3561)

Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>

(cherry picked from commit 1536570)
protectionsmachine pushed a commit that referenced this pull request Apr 3, 2024
@herrBez @github-actions
Add filebeat-* index pattern to rules based on system.auth dataset (#…
58e1a75 
…3561)

Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>

(cherry picked from commit 1536570)
protectionsmachine pushed a commit that referenced this pull request Apr 3, 2024
@herrBez @github-actions
Add filebeat-* index pattern to rules based on system.auth dataset (#…
6623059 
…3561)

Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>

(cherry picked from commit 1536570)
protectionsmachine pushed a commit that referenced this pull request Apr 3, 2024
@herrBez @github-actions
Add filebeat-* index pattern to rules based on system.auth dataset (#…
18b5d5a 
…3561)

Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>

(cherry picked from commit 1536570)
protectionsmachine pushed a commit that referenced this pull request Apr 3, 2024
@herrBez @github-actions
Add filebeat-* index pattern to rules based on system.auth dataset (#…
6921142 
…3561)

Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>

(cherry picked from commit 1536570)
protectionsmachine pushed a commit that referenced this pull request Apr 3, 2024
@herrBez @github-actions
Add filebeat-* index pattern to rules based on system.auth dataset (#…
2812118 
…3561)

Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>

(cherry picked from commit 1536570)
protectionsmachine pushed a commit that referenced this pull request Apr 3, 2024
@herrBez @github-actions
Add filebeat-* index pattern to rules based on system.auth dataset (#…
a6ea41c 
…3561)

Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>

(cherry picked from commit 1536570)
protectionsmachine pushed a commit that referenced this pull request Apr 3, 2024
@herrBez @github-actions
Add filebeat-* index pattern to rules based on system.auth dataset (#…
7a2f3da 
…3561)

Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>

(cherry picked from commit 1536570)
protectionsmachine pushed a commit that referenced this pull request Apr 3, 2024
@herrBez @github-actions
Add filebeat-* index pattern to rules based on system.auth dataset (#…
b377e01 
…3561)

Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>

(cherry picked from commit 1536570)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w0rk3r w0rk3r w0rk3r approved these changes

@Aegrah Aegrah Aegrah approved these changes

Assignees

@Aegrah Aegrah

Labels
backport: auto Domain: Endpoint OS: Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Rule Tuning] Add filebeat-* index pattern to system.auth dataset rules
3 participants
@herrBez @w0rk3r @Aegrah