Skip to content

[FR][DAC] Unit Test Locked Version Support for Custom Config #3682

Closed
@eric-forte-elastic

Description

@eric-forte-elastic

Summary

Currently when specifying a custom directory some of the unit tests in DAC fail. Specifically these are locked versions related checks. Since the branches specified in the stack-schema-map are expected to be different in a custom config, we will need a way to handle cases where customers wish to run unit tests with these custom configs.

I see two different approaches that we could take to address this problem, or we could use a combination of both.

  1. We could use the unit tests configs to have users bypass these checks by default unless they would like to have them.
  2. We could use the bypass_version_lock config value when merged to also apply for these test cases

Example:
tests/test_gh_workflows.py which tests that the default versions in the lock-versions workflow mirror those from the schema-map.
lock_version_test

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions