Inline fields of inlined types #25
Conversation
|
💚 CLA has been signed |
|
Originally fields of all embedded types were inlined (including named types such as |
|
Requesting review from @thbkrkr |
| if p.shouldIgnoreType(types.Key(typeDef)) { | ||
| zap.S().Debugw("Skipping excluded type", "type", typeDef.String()) | ||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this breaks the ignoreTypes setting which seems to be now ignored: https://github.com/elastic/cloud-on-k8s/pull/7608/files#discussion_r1528299014
| @@ -355,10 +356,6 @@ func (p *processor) loadType(pkg *loader.Package, t gotypes.Type, depth int) *ty | |||
| } | |||
|
|
|||
| typeDef := mkType(pkg, t) | |||
| if p.shouldIgnoreType(types.Key(typeDef)) { | |||
There was a problem hiding this comment.
I think this breaks the ignoreTypes setting which seems to be now ignored: https://github.com/elastic/cloud-on-k8s/pull/7608/files#discussion_r1528299014
Or maybe it's this one... I'm lost...
| for name, t := range gvi.types { | ||
| key := types.Key(t) | ||
|
|
||
| if p.shouldIgnoreType(key) { |
There was a problem hiding this comment.
I think this is too late as it does not prevent some excluded types from being referenced.
Closes #22