Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use latest beats for agent v2 #508

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Conversation

olegsu
Copy link
Contributor

@olegsu olegsu commented Nov 9, 2022

What does this PR do?
In the agent v2 pr we used to replace github.com/elastic/beats/v7 with a module that supports v2.
The CI step in the main branch failed on the licensing step.
When this PR will be merged we can remove the replace

Related tasks:

@olegsu olegsu requested a review from a team as a code owner November 9, 2022 17:31
@mergify mergify bot assigned olegsu Nov 9, 2022
@mergify
Copy link

mergify bot commented Nov 9, 2022

This pull request does not have a backport label. Could you fix it @olegsu? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Nov 9, 2022
Copy link
Contributor

@eyalkraft eyalkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity test required

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

@olegsu olegsu requested a review from a team as a code owner November 9, 2022 18:23
@olegsu olegsu force-pushed the agent-v2-fix branch 2 times, most recently from c592969 to c94122d Compare November 9, 2022 18:32
@olegsu
Copy link
Contributor Author

olegsu commented Nov 10, 2022

The latest version in pkg.go.dev is not updated.
So to make sure we are running the module on the latest commit in run from the beats repo

git --no-pager show --quiet --abbrev=12   --format="%h"

After that go get -v github.com/elastic/beats/v7@2e61bb8369f1 and go mod tidy
@cmacknz This might cause issues for other clients that use this package

@olegsu olegsu enabled auto-merge (squash) November 10, 2022 09:04
Copy link
Contributor

@yashtewari yashtewari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@olegsu olegsu merged commit 672f8f8 into elastic:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants