Fixes for some e2e tests #1284
Merged
Fixes for some e2e tests #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue is that the ES name is too long to support all the suffixes we add for the child resources, correct? Should we set a length maximum on the ES CRD to prevent this in the future? 👍 to these changes though, just wondering if we also want to do more |
anyasabo
approved these changes
Jul 18, 2019
barkbay
added a commit
to barkbay/cloud-on-k8s
that referenced
this pull request
Jul 23, 2019
barkbay
added a commit
that referenced
this pull request
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1258 and two other e2e tests in which the resource name is too long