Allow to test Logstash logs with json formatted #9959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
module
review
Filebeat
This was referenced Jan 9, 2019
webmat
approved these changes
Jan 9, 2019
There was a problem hiding this comment.
LGTM
Tried it and it works beautifully. I think we're good with this convention for now.
We can improve this later, when we want to tackle more scenarios in the integration tests, such as considering the timezone.
Did you also have to git add --force for the JSON expected logs? My git refuses to consider them and I don't know where the files are ignored :-)
|
@webmat My IDE did it automatically, so not sure for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.