Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version of python elasticsearch client to 6.3.1 #9557

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Update version of python elasticsearch client to 6.3.1 #9557

merged 1 commit into from
Dec 17, 2018

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Dec 14, 2018

When running make update the following error message was shown:

elasticsearch 6.2.0 has requirement urllib3<1.23,>=1.21.1, but you'll have urllib3 1.23 which is incompatible.

Updating Elasticsearch Python client to 6.3.1 should solve this issue.

@ruflin
Update version of python elasticsearch client to 6.3.1
1675ae5 
When running `make update` the following error message was shown:

```
elasticsearch 6.2.0 has requirement urllib3<1.23,>=1.21.1, but you'll have urllib3 1.23 which is incompatible.
```

Updating Elasticsearch Python client to 6.3.1 should solve this issue.
@ruflin ruflin requested a review from a team as a code owner December 14, 2018 15:40
@ruflin ruflin self-assigned this Dec 14, 2018
webmat
webmat approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Only other req.txt I saw elasticsearch is ./dev-tools/requirements.txt, where it's not version pinned.

@ruflin ruflin merged commit 952d922 into elastic:master Dec 17, 2018
@ruflin ruflin deleted the fix-es-python-version branch December 17, 2018 07:44
@ruflin
Copy link
Contributor Author

ruflin commented Dec 17, 2018

Merged as it fixes an existing issue. Good point about the ./dev-tools/requirements.txt file. We should probably also fix the versions there.

@webmat webmat mentioned this pull request Dec 17, 2018
Merged
@webmat webmat added the needs_backport PR is waiting to be backported to other branches. label Dec 17, 2018
ruflin added a commit to ruflin/beats that referenced this pull request Dec 18, 2018
@ruflin
Update version of python elasticsearch client to 6.3.1 (elastic#9557)
ae4611a 
When running `make update` the following error message was shown:

```
elasticsearch 6.2.0 has requirement urllib3<1.23,>=1.21.1, but you'll have urllib3 1.23 which is incompatible.
```

Updating Elasticsearch Python client to 6.3.1 should solve this issue.

(cherry picked from commit 952d922)
@ruflin ruflin mentioned this pull request Dec 18, 2018
Merged
@ruflin ruflin added v6.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 18, 2018
ruflin added a commit that referenced this pull request Dec 18, 2018
@ruflin
Update version of python elasticsearch client to 6.3.1 (#9557) (#9608)
8f3fe2e 
When running `make update` the following error message was shown:

```
elasticsearch 6.2.0 has requirement urllib3<1.23,>=1.21.1, but you'll have urllib3 1.23 which is incompatible.
```

Updating Elasticsearch Python client to 6.3.1 should solve this issue.

(cherry picked from commit 952d922)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmat webmat webmat approved these changes

Assignees

@ruflin ruflin

Labels
review :Testing v6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruflin @webmat