Haproxy fileset http renamed to log#8405
Merged
sayden merged 1 commit intoelastic:masterfrom Sep 25, 2018
Merged
Conversation
Member
|
@sayden you will need to run |
sayden
force-pushed
the
renaming_of_http_filebeat_on_haproxy
branch
from
b5a52ec to
76f8a40
Compare
Contributor
Author
Yeap, I always forget this. Done and pushed |
13 tasks
jsoriano
reviewed
Sep 24, 2018
Member
There was a problem hiding this comment.
I think this is the only change that should be done to this file, see #8401
Contributor
Author
There was a problem hiding this comment.
It must have been something related with make update command because tests are passing. :| Means, I haven't directly touched those lines.
sayden
force-pushed
the
renaming_of_http_filebeat_on_haproxy
branch
from
76f8a40 to
bf4e4cf
Compare
Contributor
Author
|
I have updated the branch and the failed test is about metricbeat... :| |
jsoriano
approved these changes
Sep 24, 2018
Member
jsoriano
left a comment
jsoriano
left a comment
There was a problem hiding this comment.
It LGTM, failing tests are not related.
Member
|
Failing test is #8412 |
sayden
added a commit
to sayden/beats
that referenced
this pull request
Sep 25, 2018
(cherry picked from commit 058916c)
sayden
added a commit
that referenced
this pull request
Sep 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to achieve a "plug & play" solution for most of Haproxy logging needs as described here elastic/integrations#3250 we have to rename current fileset called
httpto a generic name likelog.Now we want to parse
tcploganddefaultlog formats that could be interleaved in the same log file. It would be misleading if the fileset is calledhttpwhere we are doing also other kinds of log parsing.