Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the dev-tools/set_version script #8058

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Aug 22, 2018

Updated to two recent changes:

  • The file contains a copyright notice at the top
  • The version is only kept in the Go file now

Updated to two recent changes:
* The file contains a copyright notice at the top
* The version is only kept in the Go file now
@tsg tsg added needs_backport PR is waiting to be backported to other branches. review v7.0.0-alpha1 labels Aug 22, 2018
@tsg tsg requested a review from andrewkroh August 22, 2018 21:35
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this.

@andrewkroh andrewkroh merged commit 0c18e71 into elastic:master Aug 23, 2018
tsg added a commit to tsg/beats that referenced this pull request Aug 23, 2018
There was an error in elastic#8058, where no new line was added at the
end of the generated file, causing `go vet` to fail.
@tsg tsg mentioned this pull request Aug 23, 2018
ruflin pushed a commit that referenced this pull request Aug 24, 2018
There was an error in #8058, where no new line was added at the
end of the generated file, causing `go vet` to fail.
tsg added a commit to tsg/beats that referenced this pull request Sep 17, 2018
There was an error in elastic#8058, where no new line was added at the
end of the generated file, causing `go vet` to fail.

(cherry picked from commit 9f3a8d2)
tsg added a commit to tsg/beats that referenced this pull request Sep 17, 2018
There was an error in elastic#8058, where no new line was added at the
end of the generated file, causing `go vet` to fail.

(cherry picked from commit 9f3a8d2)
@exekias exekias mentioned this pull request Sep 17, 2018
ruflin pushed a commit to ruflin/beats that referenced this pull request Oct 1, 2018
Updated to two recent changes:
* The file contains a copyright notice at the top
* The version is only kept in the Go file now

(cherry picked from commit 0c18e71)
@ruflin ruflin added v6.5.0 and removed needs_backport PR is waiting to be backported to other branches. labels Oct 1, 2018
ruflin added a commit that referenced this pull request Oct 1, 2018
Updated to two recent changes:
* The file contains a copyright notice at the top
* The version is only kept in the Go file now

(cherry picked from commit 0c18e71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants