Cherry-pick #7887 to 6.4: Allow custom port in cloud.id #7904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible for the cloud.id to contain a custom port. If the port is not specified, 443 is used, like before. The custom port can be specified in multiple ways. The cloudid is formed like this: `<host>:<es-id>:<kb-id>`. The port can be specified either in es-id or kb-id, or in the host section. If specified in both, the more specific one wins (i.e. es-id over host). Examples: ``` 'us-central1.gcp.cloud.es.io:9243$ac31ebb90241773157043c34fd26fd46$a4c06230e48c8fce7be88a074a3bb3e0' ``` Results in: ``` ES: https://ac31ebb90241773157043c34fd26fd46.us-central1.gcp.cloud.es.io:9243 KB: https://a4c06230e48c8fce7be88a074a3bb3e0.us-central1.gcp.cloud.es.io:9243 ``` Or: ``` 'us-central1.gcp.cloud.es.io$ac31ebb90241773157043c34fd26fd46:9243$a4c06230e48c8fce7be88a074a3bb3e0:9244' ``` Results in: ``` ES: https://ac31ebb90241773157043c34fd26fd46.us-central1.gcp.cloud.es.io:9243 KB: https://a4c06230e48c8fce7be88a074a3bb3e0.us-central1.gcp.cloud.es.io:9244 ``` Closes: elastic#7794. (cherry picked from commit daaca33)
kvch
approved these changes
Aug 8, 2018
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Make it possible for the cloud.id to contain a custom port. If the port is not specified, 443 is used, like before. The custom port can be specified in multiple ways. The cloudid is formed like this: `<host>:<es-id>:<kb-id>`. The port can be specified either in es-id or kb-id, or in the host section. If specified in both, the more specific one wins (i.e. es-id over host). Examples: ``` 'us-central1.gcp.cloud.es.io:9243$ac31ebb90241773157043c34fd26fd46$a4c06230e48c8fce7be88a074a3bb3e0' ``` Results in: ``` ES: https://ac31ebb90241773157043c34fd26fd46.us-central1.gcp.cloud.es.io:9243 KB: https://a4c06230e48c8fce7be88a074a3bb3e0.us-central1.gcp.cloud.es.io:9243 ``` Or: ``` 'us-central1.gcp.cloud.es.io$ac31ebb90241773157043c34fd26fd46:9243$a4c06230e48c8fce7be88a074a3bb3e0:9244' ``` Results in: ``` ES: https://ac31ebb90241773157043c34fd26fd46.us-central1.gcp.cloud.es.io:9243 KB: https://a4c06230e48c8fce7be88a074a3bb3e0.us-central1.gcp.cloud.es.io:9244 ``` Closes: elastic#7794. (cherry picked from commit 8d8ac27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #7887 to 6.4 branch. Original message:
Make it possible for the the cloud.id to contain a custom port. If the port is not specified, 443 is used, like before.
The custom port can be specified in multiple ways. The cloudid is formed like this:
<host>:<es-id>:<kb-id>. The port can be specified either in es-id or kb-id, or in the host section. If specified in both, the more specific one wins (i.e. es-id over host).Examples:
Results in:
Or:
Results in:
This is proposed fix for #7794.