Assert now takes into consideration the license. #7855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- License headers for both Elastic and ASL2 are now accessible by
code using the licenses package.
```
licenses.Elastic
licenses.ASL2
```
- Added a generator to take care of syncing the files in the licenses/
directory.
- Added `LICENSE` as a variable for the makefile to configure the
go-licenser this is useful if a beat as a different license.
ph
commented
Aug 3, 2018
| ) | ||
|
|
||
| var Template = template.Must(template.New("licenseheader").Parse(` | ||
| {{ $t := "` + "`" + `" }} |
There was a problem hiding this comment.
Haven't found a better way to embed ticks in ticks :(
ph
commented
Aug 3, 2018
| @@ -0,0 +1,58 @@ | |||
| // Licensed to Elasticsearch B.V. under one or more contributor | |||
There was a problem hiding this comment.
+1 for multiple licenses.. ;)
|
@ruflin can you take a look at this? |
ruflin
reviewed
Aug 8, 2018
|
|
||
| content, err = ioutil.ReadFile("ELASTIC-LICENSE-header.txt") | ||
| if err != nil { | ||
| panic("could not read Elastic license.") |
There was a problem hiding this comment.
any reason you use panic instead of os.Exit(1)
There was a problem hiding this comment.
no specific I could have use println + os.Exit(1)
andrewkroh
pushed a commit
to andrewkroh/beats
that referenced
this pull request
Oct 24, 2018
- License headers for both Elastic and ASL2 are now accessible by
code using the licenses package.
```
licenses.Elastic
licenses.ASL2
```
- Added a generator to take care of syncing the files in the licenses/
directory.
- Added `LICENSE` as a variable for the makefile to configure the
go-licenser this is useful if a beat as a different license.
(cherry picked from commit 437a62a)
andrewkroh
added a commit
that referenced
this pull request
Oct 24, 2018
- License headers for both Elastic and ASL2 are now accessible by
code using the licenses package.
```
licenses.Elastic
licenses.ASL2
```
- Added a generator to take care of syncing the files in the licenses/
directory.
- Added `LICENSE` as a variable for the makefile to configure the
go-licenser this is useful if a beat as a different license.
(cherry picked from commit 437a62a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code using the licenses package.
directory.
LICENSEas a variable for the makefile to configure thego-licenser this is useful if a beat as a different license.