Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for kafka log values #6101

Closed
wants to merge 1 commit into from
Closed

Fix for kafka log values #6101

wants to merge 1 commit into from

Conversation

anx-mr
Copy link

@anx-mr anx-mr commented Jan 18, 2018

No description provided.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@anx-mr anx-mr changed the base branch from 6.1 to master January 18, 2018 09:32
@anx-mr anx-mr changed the base branch from master to 6.1 January 18, 2018 09:32
@anx-mr anx-mr changed the title Fix for log values Fix for kafka log values Jan 18, 2018
@ruflin
Copy link
Contributor

ruflin commented Jan 18, 2018

@anx-mr Can you share some more background on this?

@ruflin ruflin added in progress Pull request is currently in progress. :Outputs labels Jan 18, 2018
@ruflin ruflin requested a review from urso January 18, 2018 22:41
@anx-mr
Copy link
Author

anx-mr commented Jan 19, 2018

The arguments are passed as slice (v) instead of a argument list (v...) which results in a wrong output in the log.

`2018/01/19 08:52:06.563449 log.go:36: INFO client/brokers registered new broker #[[3 %!d(string=server03.local:9093)]] at %!s(MISSING)

2018/01/19 08:52:06.563455 log.go:36: INFO client/brokers registered new broker #[[6 %!d(string=server06.local:9093)]] at %!s(MISSING)

2018/01/19 08:52:06.563492 log.go:36: INFO kafka message: [Successfully initialized new client]

2018/01/19 08:52:06.563663 log.go:36: INFO producer/broker/[[6]] starting up

2018/01/19 08:52:06.563679 log.go:36: INFO producer/broker/[[6 %!d(string=topic1) 0]] state change to [open] on %!s(MISSING)/%!d(MISSING)

2018/01/19 08:52:06.666677 log.go:36: INFO Connected to broker at [[server06.local:9093 %!s(int32=6)]] (registered as #%!d(MISSING))

2018/01/19 08:52:11.335943 log.go:36: INFO producer/broker/[[7]] starting up

2018/01/19 08:52:11.335995 log.go:36: INFO producer/broker/[[7 %!d(string=topic1) 1]] state change to [open] on %!s(MISSING)/%!d(MISSING)

2018/01/19 08:52:11.456625 log.go:36: INFO Connected to broker at [[server07.local:9093 %!s(int32=7)]] (registered as #%!d(MISSING))`

@ruflin
Copy link
Contributor

ruflin commented Jan 21, 2018

jenkins, test it

@ruflin ruflin added review and removed in progress Pull request is currently in progress. labels Jan 21, 2018
@ruflin
Copy link
Contributor

ruflin commented Jan 21, 2018

@urso We should probably forward port to this master and 6.2?

@ruflin ruflin added the needs_backport PR is waiting to be backported to other branches. label Jan 21, 2018
@urso
Copy link

urso commented Jan 22, 2018

@ruflin @anx-mr Oh, didn't notice this PR is on 6.1. Can you please open the PR on the master branch? I will take care of backporting the fix to all 6.x branches. Please add a changelog entry to Changelog.asciidoc as well.

@anx-mr
Copy link
Author

anx-mr commented Feb 21, 2018

Closed, new pull request for master: #6430

@anx-mr anx-mr closed this Feb 21, 2018
@urso urso removed the needs_backport PR is waiting to be backported to other branches. label Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants