Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the _all field settings from the 5.x template (master/6.0 version) #4928

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Aug 16, 2017

Part of #4901.

This also updates the 5.x.yml testing env to use 5.5.1.

@tsg tsg added review in progress Pull request is currently in progress. labels Aug 16, 2017
@tsg tsg changed the title Remove the _all field from the 5.x template (master/6.0 version) Remove the _all field settings from the 5.x template (master/6.0 version) Aug 18, 2017
Part of elastic#4901. The removal of the `norms: false` _all setting results in a storage
increase of one byte per doc, but this smooths the upgrade experience.
@tsg tsg force-pushed the remove_all_field_master branch from 3f64e9c to a5043d6 Compare August 18, 2017 09:55
@tsg
Copy link
Contributor Author

tsg commented Aug 18, 2017

Updated PR to remove the _all settings, rather than explicitly disable the field.

@tsg tsg removed the in progress Pull request is currently in progress. label Aug 18, 2017
@tsg
Copy link
Contributor Author

tsg commented Aug 18, 2017

Should be read for reviews again.

@tsg tsg added needs_backport PR is waiting to be backported to other branches. v6.0.0-beta2 labels Aug 18, 2017
@exekias exekias merged commit 33c0897 into elastic:master Aug 18, 2017
tsg added a commit to tsg/beats that referenced this pull request Aug 18, 2017
Part of elastic#4901. The removal of the `norms: false` _all setting results in a storage
increase of one byte per doc, but this smooths the upgrade experience.

(cherry picked from commit 33c0897)
@tsg tsg removed the needs_backport PR is waiting to be backported to other branches. label Aug 18, 2017
exekias pushed a commit that referenced this pull request Aug 18, 2017
Part of #4901. The removal of the `norms: false` _all setting results in a storage
increase of one byte per doc, but this smooths the upgrade experience.

(cherry picked from commit 33c0897)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…stic#4948)

Part of elastic#4901. The removal of the `norms: false` _all setting results in a storage
increase of one byte per doc, but this smooths the upgrade experience.

(cherry picked from commit d6ed786)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants