[8.19](backport #48414) Refactor and update packetbeat DHCP parsers#48735
Open
mergify[bot] wants to merge 1 commit into8.19from
Open
[8.19](backport #48414) Refactor and update packetbeat DHCP parsers#48735mergify[bot] wants to merge 1 commit into8.19from
mergify[bot] wants to merge 1 commit into8.19from
Conversation
* working * fix typo * format * add changelog * cleanup * still cleaning up * add tests * update changelog * update go files (cherry picked from commit a64fa45) # Conflicts: # go.mod # go.sum
Contributor
Author
|
Cherry-pick of a64fa45 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
6 tasks
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This is a rather large PR that completely updates the DHCPv4 parser for a number of reasons:
routerallow for multiple address fields, although we only parsed the first field.Putting this in draft, as there's portions of the code I need to clean up, and I would like to add more tests.
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
The
routerfield now returns a list, and not a single address. Returning a single address is technically not in spec, and was a bug.This is an automatic backport of pull request #48414 done by [Mergify](https://mergify.com).