[osquerybeat] Add elastic_browser_history spec#48733
Open
marc-gr wants to merge 5 commits intoelastic:mainfrom
Open
[osquerybeat] Add elastic_browser_history spec#48733marc-gr wants to merge 5 commits intoelastic:mainfrom
marc-gr wants to merge 5 commits intoelastic:mainfrom
Conversation
- Updated osqueryTypeToGoType function to include mapping for BOOLEAN and BOOL to Go's bool type. - Enhanced README to reflect the addition of BOOLEAN in the column type specifications.
… and structure - Changed the README to link to the new documentation file for the elastic_browser_history table. - Deleted the old documentation file and created a new structured documentation file under docs/tables. - Registered the elastic_browser_history table across all platforms (Linux, macOS, Windows) with appropriate schema and examples. - Enhanced the generated code for the elastic_browser_history table to include detailed column definitions and data model descriptions.
…lt structs - Introduced a new `Result` struct for browser history entries, enhancing type safety and clarity. - Updated parsing functions across Chromium, Firefox, and Safari to return the new `Result` type instead of the previous `visit` type. - Replaced instances of `GetTableRows` with a new helper function `getResultsAsMaps` for test data conversion. - Removed the deprecated `visit` struct and related functions to streamline the codebase. - Enhanced error handling and logging during browser history parsing.
…m all platforms - Removed the registration of the `elastic_browser_history` plugin from the macOS, Linux, and Windows implementations.
marc-gr
added
enhancement
Osquerybeat
backport-skip
botelastic
bot
added
the
needs_team
Contributor
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
botelastic
bot
removed
the
needs_team
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
Vale Linting ResultsSummary: 7 warnings, 3 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| x-pack/osquerybeat/ext/osquery-extension/docs/tables/elastic_browser_history.md | 28 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| x-pack/osquerybeat/ext/osquery-extension/docs/tables/elastic_browser_history.md | 49 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| x-pack/osquerybeat/ext/osquery-extension/docs/tables/elastic_browser_history.md | 50 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
| x-pack/osquerybeat/ext/osquery-extension/docs/tables/elastic_browser_history.md | 165 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| x-pack/osquerybeat/ext/osquery-extension/docs/tables/elastic_browser_history.md | 187 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| x-pack/osquerybeat/ext/osquery-extension/docs/tables/elastic_browser_history.md | 189 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| x-pack/osquerybeat/ext/osquery-extension/docs/tables/elastic_browser_history.md | 190 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
💡 Suggestions (3)
| File | Line | Rule | Message |
|---|---|---|---|
| x-pack/osquerybeat/ext/osquery-extension/docs/tables/elastic_browser_history.md | 26 | Elastic.Semicolons | Use semicolons judiciously. |
| x-pack/osquerybeat/ext/osquery-extension/docs/tables/elastic_browser_history.md | 28 | Elastic.Semicolons | Use semicolons judiciously. |
| x-pack/osquerybeat/ext/osquery-extension/docs/tables/elastic_browser_history.md | 189 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Convert the elastic_browser_history table to use the spec.
This will autogenerate and validate the types, documentation, and table registration.
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.