[iis][windows] Adds cpu number information to IIS module and Windows perfmon dataset#48637
Conversation
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
@giorgi-imerlishvili-elastic Is there an open issue for this? If not, could you update PR description with "Why this change is required and what does it fix/enhance?" |
Just added description and related issues |
VihasMakwana
left a comment
There was a problem hiding this comment.
just a nit. LGTM otherwise
jmikell821
left a comment
There was a problem hiding this comment.
Just a couple of slight comments, thanks!
| Webserver related metrics. | ||
|
|
||
| **`iis.webserver.host.cpu.count`** | ||
| : Number of CPUs host have |
There was a problem hiding this comment.
| : Number of CPUs host have | |
| : Number of CPUs the host has |
| - name: host.cpu.count | ||
| type: long | ||
| description: > | ||
| Number of CPUs host have |
There was a problem hiding this comment.
| Number of CPUs host have | |
| Number of CPUs the host has |
…-elastic/beats into iis-show-cpu-number2
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
Proposed commit message
Adds cpu number information to IIS module and Windows perfmon dataset
Purpose of this change is to help customers have better view on CPU performance. For example with IIS module customer is able to see CPU load but currently it doesn't have ability to show how many CPU are there in total. This sometimes might lead to confusion because currently CPU load is provided with percents where maximum percent cap is calculated via this formula: from 0 through 100 * ProcessorCount (source: https://learn.microsoft.com/en-us/windows/win32/perfctrs/collecting-performance-data). So when someone sees for example CPU load: 155% without knowing CPU number, they won't be able to calculate cap.
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs