-
Notifications
You must be signed in to change notification settings - Fork 5k
[8.19](backport #45734) refactor: replace lopg.ObserverLogs with logptest #47463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 8.19
Are you sure you want to change the base?
Conversation
* refactor: replace lopg.ObserverLogs with logptest ObserverLogs is relying on a testing package in a non-test package move to logptest * lint: regenerate notice file * test: update to NewTestingLoggerWithObserver * lint: regenerate notice * lint: remove unused imports * lint: remove unused imports * Update console_test.go * lint: fix linter issues (cherry picked from commit b5789af) # Conflicts: # filebeat/input/filestream/config_test.go # filebeat/input/journald/pkg/journalctl/reader_test.go # libbeat/autodiscover/autodiscover_test.go
|
Cherry-pick of b5789af has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
This pull request has not been merged yet. Could you please review and merge it @kruskall? 🙏 |
1 similar comment
|
This pull request has not been merged yet. Could you please review and merge it @kruskall? 🙏 |
Proposed commit message
ObserverLogs is relying on a testing package in a non-test package
move to logptest
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
This is an automatic backport of pull request #45734 done by [Mergify](https://mergify.com).