[8.x](backport #42663) Improve the wmi beats module 42650 #43856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Add the Domain parameter. Remove reference to the IP address * Add the domain to the wmi data * Improve the documentation of the WMI module - Add [float] to the internal sections - Mention all parameters - Make sure the examples has two queries and one of them uses where and namespace - Show an example of how to convert an WQL query into a YAML Configuration * Update metricbeat/module/windows/wmi/_meta/docs.asciidoc Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com> * Update metricbeat/module/windows/wmi/_meta/docs.asciidoc Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com> * Add wmi.namespace and rewrite the Configuration section * Add section about best-practice and about Arbitrator * Improve phrasing of the best practices section * Fix the convertDateTime function and add a test for the dates with timezone * Refactor replace fields with properties to be compliant with WMI documentation * Refactor the wmi.include_null and wmi.include_empty_string to a more explicit wmi.include_null_properties and wmi.include_empty_string * Run make update * Make the warning more accurate * Fix typo * Fix linting error * fix the example of the documentation + reorder the parameter definition to be the same of the example * remove reference to fields that should have been removed with the refactoring * fix typos and make sure the period is 10 minutes in our examples * Fix the name of the test * Hide the Remote WMI parameters * Remove remote wmi logic from wmi.go. This can be reactivated by need * Get rid of unicode import that was causing issues with the CI/CD pipeline * Double check the return value of getVariantValue to please CI and avoid panic * Port documentation from Asciidoc to Markdown * Using bold instead of title to make the doc fit one page * Revert "Using bold instead of title to make the doc fit one page" This reverts commit 7ff2b08. * Revert "Port documentation from Asciidoc to Markdown" This reverts commit 926588b. * Porting Documentation changes into markdown * Improve markdown documentation --------- Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com> (cherry picked from commit ab1a0e0) # Conflicts: # docs/reference/metricbeat/metricbeat-metricset-windows-wmi.md
mergify
bot
added
backport
conflicts
mergify
bot
requested review from
mauri870 and
faec
and removed request for
a team
|
Cherry-pick of ab1a0e0 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
botelastic
bot
added
the
needs_team
github-actions
bot
added
Team:Elastic-Agent-Data-Plane
botelastic
bot
removed
the
needs_team
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
Hi there, what I am supposed to do? Did mergify fix the issue on its own? I'd like to avoid breaking the 8.x branch :) |
|
It looks like everything has been resolved but I would prefer to get a confirmation from @faec or someone else in the team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Improve the WMI Module Documentation
Add the domain parameter
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
This is an automatic backport of pull request #42663 done by Mergify.