Skip to content

Add FIPS check for .deb artifacts #43782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged

Conversation

pchila
Copy link
Member

@pchila pchila commented Apr 8, 2025

Proposed commit message

Add a FIPS check for FIPS .deb package tests.
The check is performed by extracting the data.tar.gz from the .deb archive and verifying that the binaries are compiled with the correct settings for FIPS compliance.

This PR is a follow-up for PR #43001

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@pchila pchila added enhancement Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Apr 8, 2025
@pchila pchila requested a review from leehinman April 8, 2025 14:16
@pchila pchila self-assigned this Apr 8, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 8, 2025
@pchila pchila force-pushed the add-deb-fips-check branch from c756e0f to 0dfa949 Compare April 8, 2025 14:16
Copy link
Contributor

mergify bot commented Apr 8, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @pchila? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@pchila pchila mentioned this pull request Apr 8, 2025
6 tasks
@pchila
Copy link
Member Author

pchila commented Apr 9, 2025

buildkite test this

@pchila pchila force-pushed the add-deb-fips-check branch from c2aafbc to d2bc15b Compare April 9, 2025 11:47
@pchila pchila marked this pull request as ready for review April 10, 2025 06:36
@pchila pchila requested a review from a team as a code owner April 10, 2025 06:36
@pchila pchila requested review from AndersonQ and belimawr April 10, 2025 06:36
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pchila pchila merged commit 3af6b7c into elastic:main Apr 14, 2025
182 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIPS] Add package tests for FIPS .deb packages
4 participants