-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Update the log
to filestream
migration guide
#43641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
75e6d9f
to
c1d7d9e
Compare
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not attempted to reproduce, but overall it's a good coverage. Thank you @rdner!
Would it be possible to add an example for the container
input in concomitance with autodiscover in the migration?
It's a good point, @lucabelluccini. I'm going to add a As a part of this PR, the autodiscover docs were also updated to reflect the migration: there are warnings in the |
3a71eb5
to
f2e49d0
Compare
To better reflect the current state of the migration flow and give more details and context. Also, all the steps are listed on the same page now which improves the navigation.
f2e49d0
to
1d9c468
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the [NIT]
comments are me in pedantic mode, fell free to ignore them. The [Suggestion]
, I think are valuable, but I won't make a stand if you disagree.
There are 2 [Blocker]
I believe which needs to be addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Very nice!
@kilfoyle @karenzone I think it's safe to say it's ready for your review here. I only need to test some code snippets meanwhile. |
Never mind, Github didn't update the comments for me when I was writing mine. Thanks! |
To better reflect the current state of the migration flow and give more details and context. Also, all the steps are listed on the same page now which improves the navigation. (cherry picked from commit 8d25694) # Conflicts: # docs/reference/filebeat/_debugging_on_kibana.md # docs/reference/filebeat/_step_1_set_an_identifier_for_each_filestream_input.md # docs/reference/filebeat/_step_2_enable_the_take_over_mode.md # docs/reference/filebeat/_step_3_use_new_option_names.md # docs/reference/filebeat/_step_4.md # docs/reference/filebeat/howto-guides.md # docs/reference/toc.yml
Thanks all for this again! |
…de (#43788) * Update the `log` to `filestream` migration guide (#43641) To better reflect the current state of the migration flow and give more details and context. Also, all the steps are listed on the same page now which improves the navigation. (cherry picked from commit 8d25694) # Conflicts: # docs/reference/filebeat/_debugging_on_kibana.md # docs/reference/filebeat/_step_1_set_an_identifier_for_each_filestream_input.md # docs/reference/filebeat/_step_2_enable_the_take_over_mode.md # docs/reference/filebeat/_step_3_use_new_option_names.md # docs/reference/filebeat/_step_4.md # docs/reference/filebeat/howto-guides.md # docs/reference/toc.yml * Resolve conflict * Resolve conflict --------- Co-authored-by: Denis <denis.rechkunov@elastic.co>
To better reflect the current state of the migration flow and give more details and context.
Also, all the steps are listed on the same page now which improves the navigation.
The preview of the migration guide is here https://docs-v3-preview.elastic.dev/elastic/beats/pull/43641/reference/filebeat/migrate-to-filestream
I'm going to follow the migration steps myself once again to make sure it still works as I describe it in this PR. Reviewers, feel free to try it out too.