Skip to content

Update the log to filestream migration guide #43641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025

Conversation

rdner
Copy link
Member

@rdner rdner commented Apr 2, 2025

To better reflect the current state of the migration flow and give more details and context.

Also, all the steps are listed on the same page now which improves the navigation.

The preview of the migration guide is here https://docs-v3-preview.elastic.dev/elastic/beats/pull/43641/reference/filebeat/migrate-to-filestream

I'm going to follow the migration steps myself once again to make sure it still works as I describe it in this PR. Reviewers, feel free to try it out too.

@rdner rdner added docs Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-9.0 Automated backport to the 9.0 branch labels Apr 2, 2025
@rdner rdner self-assigned this Apr 2, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 2, 2025
@rdner rdner force-pushed the log-input-deprecation-docs branch 2 times, most recently from 75e6d9f to c1d7d9e Compare April 2, 2025 13:33
@rdner rdner marked this pull request as ready for review April 2, 2025 13:46
@rdner rdner requested a review from a team as a code owner April 2, 2025 13:46
@rdner rdner requested review from AndersonQ and khushijain21 April 2, 2025 13:46
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@rdner rdner requested review from lucabelluccini, belimawr, kilfoyle and karenzone and removed request for khushijain21 April 2, 2025 13:47
Copy link
Contributor

@lucabelluccini lucabelluccini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not attempted to reproduce, but overall it's a good coverage. Thank you @rdner!

Would it be possible to add an example for the container input in concomitance with autodiscover in the migration?

@rdner
Copy link
Member Author

rdner commented Apr 2, 2025

Would it be possible to add an example for the container input in concomitance with autodiscover in the migration?

It's a good point, @lucabelluccini. I'm going to add a container input to the migration guide as a part of the example configuration.

As a part of this PR, the autodiscover docs were also updated to reflect the migration: there are warnings in the container input documentation and on each autodiscover page now. Since setting a template is identical to any other input configuration, I think it should be sufficient.

@rdner rdner marked this pull request as draft April 2, 2025 14:57
@rdner rdner force-pushed the log-input-deprecation-docs branch from 3a71eb5 to f2e49d0 Compare April 2, 2025 15:24
@rdner rdner marked this pull request as ready for review April 2, 2025 15:25
@rdner rdner requested a review from lucabelluccini April 2, 2025 15:25
To better reflect the current state of the migration flow and give
more details and context.

Also, all the steps are listed on the same page now which improves the navigation.
@rdner rdner force-pushed the log-input-deprecation-docs branch from f2e49d0 to 1d9c468 Compare April 2, 2025 15:27
Copy link
Member

@AndersonQ AndersonQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the [NIT] comments are me in pedantic mode, fell free to ignore them. The [Suggestion], I think are valuable, but I won't make a stand if you disagree.
There are 2 [Blocker] I believe which needs to be addressed.

@rdner rdner requested review from AndersonQ and belimawr April 3, 2025 13:30
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Very nice!

@rdner
Copy link
Member Author

rdner commented Apr 8, 2025

@kilfoyle @karenzone I think it's safe to say it's ready for your review here. I only need to test some code snippets meanwhile.

@rdner
Copy link
Member Author

rdner commented Apr 8, 2025

Never mind, Github didn't update the comments for me when I was writing mine. Thanks!

@rdner rdner merged commit 8d25694 into elastic:main Apr 8, 2025
11 checks passed
mergify bot pushed a commit that referenced this pull request Apr 8, 2025
To better reflect the current state of the migration flow and give
more details and context.

Also, all the steps are listed on the same page now which improves the navigation.

(cherry picked from commit 8d25694)

# Conflicts:
#	docs/reference/filebeat/_debugging_on_kibana.md
#	docs/reference/filebeat/_step_1_set_an_identifier_for_each_filestream_input.md
#	docs/reference/filebeat/_step_2_enable_the_take_over_mode.md
#	docs/reference/filebeat/_step_3_use_new_option_names.md
#	docs/reference/filebeat/_step_4.md
#	docs/reference/filebeat/howto-guides.md
#	docs/reference/toc.yml
@rdner rdner deleted the log-input-deprecation-docs branch April 8, 2025 15:36
@lucabelluccini
Copy link
Contributor

Thanks all for this again!

rdner added a commit that referenced this pull request Apr 16, 2025
…de (#43788)

* Update the `log` to `filestream` migration guide (#43641)

To better reflect the current state of the migration flow and give
more details and context.

Also, all the steps are listed on the same page now which improves the navigation.

(cherry picked from commit 8d25694)

# Conflicts:
#	docs/reference/filebeat/_debugging_on_kibana.md
#	docs/reference/filebeat/_step_1_set_an_identifier_for_each_filestream_input.md
#	docs/reference/filebeat/_step_2_enable_the_take_over_mode.md
#	docs/reference/filebeat/_step_3_use_new_option_names.md
#	docs/reference/filebeat/_step_4.md
#	docs/reference/filebeat/howto-guides.md
#	docs/reference/toc.yml

* Resolve conflict

* Resolve conflict

---------

Co-authored-by: Denis <denis.rechkunov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-9.0 Automated backport to the 9.0 branch docs Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants