-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] UpdateCLI: Added go mod tidy #41170
base: main
Are you sure you want to change the base?
Conversation
- uses: actions/setup-go@v5 | ||
with: | ||
go-version-file: .go-version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this cause any issues if the golang-bump happens afterwards? Let's say current version is 1.22.7 and the upcoming one is 1.22.8
, hence this step will point to 1.22.7
but the updatecli pipeline will move the version from 1.22.7
to 1.22.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. It's better to install the new version of go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hence, this change will not install the new version if that's the pre-req
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updatecli can neither execute a specified target nor run a subset of targets. I came up with one solution that I don't like.
- run updatecli with
--commit false --push false
. It applies the changes to the target files. - install go with GHA using updated
.go-version
- run updatecli again without
--commit false --push false
and it pushes the changes.
Please check the updates. Do you have any ideas on how can we make it in one execution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, can you explain the motivation for running go mod tidy
? I have not seen the need to use it while running the same mechanism with other golang versions:
- [Automation] Bump Golang version to 1.22.7 #41018
- [Automation] Bump Golang version to 1.22.6 #40528
- [Automation] Bump Golang version to 1.21.12 #40114
Updatecli can neither execute a specified target nor run a subset of targets.
As far as I see there is a parameter called dependson
, see https://www.updatecli.io/docs/core/target/#_parameters:
"dependson" allows to specify the order of execution of resources It accepts a list of rules like "(resourceType#)resourceId(:booleanOperator)" The resourceType is optional and can be one of "condition", "source" or "target"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this change also needed in bump-golang-7.17.yml
?
Added the same for 7.17 |
@@ -33,7 +37,7 @@ jobs: | |||
- if: ${{ failure() }} | |||
uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0 | |||
with: | |||
channel-id: '#ingest-notifications' | |||
channel-id: "#ingest-notifications" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Proposed commit message
Performs
go mod tidy
after updating the go version in go.modChecklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs