Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metricbeat): initial windows arm support #41039

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

kruskall
Copy link
Member

Proposed commit message

resolve some of the compile errors on windows arm

the remaining compile errors will be fixed once elastic/elastic-agent-system-metrics is bumped

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

resolve some of the compile errors on windows arm

the remaining compile errors will be fixed once elastic/elastic-agent-system-metrics
is bumped
@kruskall kruskall requested a review from a team as a code owner September 28, 2024 23:43
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 28, 2024
Copy link
Contributor

mergify bot commented Sep 28, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kruskall? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Sep 28, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 28, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 29, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 29, 2024
@mauri870
Copy link
Member

@kruskall Looks like you need to bump elastic/elastic-agent-system-metrics to v0.11.3 to fix some compile time errors, after that it compiles properly for windows/arm and windows/arm64. Thanks!

@kruskall
Copy link
Member Author

the remaining compile errors will be fixed once elastic/elastic-agent-system-metrics is bumped

yup, that's being taken care by #41024 😄

@kruskall kruskall merged commit 23f14f1 into elastic:main Oct 11, 2024
31 checks passed
@kruskall kruskall deleted the metricbeat/windows-arm branch October 11, 2024 18:46
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
resolve some of the compile errors on windows arm

the remaining compile errors will be fixed once elastic/elastic-agent-system-metrics
is bumped

(cherry picked from commit 23f14f1)
pierrehilbert pushed a commit that referenced this pull request Oct 13, 2024
resolve some of the compile errors on windows arm

the remaining compile errors will be fixed once elastic/elastic-agent-system-metrics
is bumped

(cherry picked from commit 23f14f1)

Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants