Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid URL and add metricsets and scope to elasticsearch-xpack.yml.disabled #40665

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jguay
Copy link
Contributor

@jguay jguay commented Aug 30, 2024

Proposed commit message

  • elasticsearch-xpack.yml.disabled contains an invalid hyperlink which is fixed
  • Also adding metricsets and scope commented-out settings for convenience/completeness
  • I wasn't sure to use doc label given the file is part of the metricbeat release I used enhancement

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas - N/A
  • I have made corresponding changes to the documentation / N/A
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works - N/A
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc. - No release notes change needed (added commented-out settings on a disabled template file and fixed a documentation URL)

Disruptive User Impact

No impact

Author's Checklist

  • Checked metricsets are the currently supported list (versus no list previously)

How to test this PR locally

  • check metricbeat compiles - there is no used file modified in this PR

elasticsearch-xpack.yml.disabled contains an invalid hyperlink which this commit fixes
Also adding commented out metricset and scope settings
@jguay jguay added enhancement Metricbeat Metricbeat monitoring release-note:skip The PR should be ignored when processing the changelog backport-skip Skip notification from the automated backport with mergify Module:elasticsearch Elasticsearch Beats modules labels Aug 30, 2024
@jguay jguay requested a review from a team as a code owner August 30, 2024 16:53
@jguay jguay requested review from faec and VihasMakwana August 30, 2024 16:53
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 30, 2024
@mergify mergify bot assigned jguay Aug 30, 2024
@ycombinator ycombinator added the Team:Monitoring Stack Monitoring team label Sep 4, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 4, 2024
@ycombinator ycombinator added backport-v8.x and removed backport-skip Skip notification from the automated backport with mergify labels Sep 10, 2024
Copy link
Contributor

mergify bot commented Sep 11, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@v1v v1v removed the backport-v8.x label Sep 11, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 16, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@VihasMakwana
Copy link
Contributor

Can you run make update under metricbeat and commit changes ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement Metricbeat Metricbeat Module:elasticsearch Elasticsearch Beats modules monitoring release-note:skip The PR should be ignored when processing the changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Monitoring Stack Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants