-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE [metricbeat][system/process] - Handle non-fatal errors #40298
base: main
Are you sure you want to change the base?
DO NOT MERGE [metricbeat][system/process] - Handle non-fatal errors #40298
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This pull request is now in conflicts. Could you fix it? 🙏
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
@cmacknz screenshot of error event on Kibana. |
@elastic/obs-ds-hosted-services can someone from you team review this? |
This pull request is now in conflicts. Could you fix it? 🙏
|
|
Proposed commit message
With elastic/elastic-agent-system-metrics#164, we now also expect a list of non-fatal errors (access denied, operation not permitted, invalid parameters etc) which will be used to update status to DEGRADED.
In this PR, we just return the errors. #40025 would take care of changing the actual status to DEGRADED.
Also,
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs