Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE [metricbeat][system/process] - Handle non-fatal errors #40298

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

VihasMakwana
Copy link
Contributor

@VihasMakwana VihasMakwana commented Jul 18, 2024

  • Enhancement

Proposed commit message

With elastic/elastic-agent-system-metrics#164, we now also expect a list of non-fatal errors (access denied, operation not permitted, invalid parameters etc) which will be used to update status to DEGRADED.
In this PR, we just return the errors. #40025 would take care of changing the actual status to DEGRADED.
Also,

  • update go.mod

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 18, 2024
Copy link
Contributor

mergify bot commented Jul 18, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @VihasMakwana? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Jul 23, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b metricbeat-process-multierr upstream/metricbeat-process-multierr
git merge upstream/main
git push upstream metricbeat-process-multierr

@VihasMakwana VihasMakwana changed the title DRAFT - [metricbeat][system/process] - Handle non-fatal errors [metricbeat][system/process] - Handle non-fatal errors Jul 23, 2024
@VihasMakwana VihasMakwana marked this pull request as ready for review July 23, 2024 09:34
@VihasMakwana VihasMakwana requested review from a team as code owners July 23, 2024 09:34
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jul 23, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 23, 2024
@pierrehilbert pierrehilbert added Team:obs-ds-hosted-services Label for the Observability Hosted Services team needs_team Indicates that the issue/PR needs a Team:* label labels Jul 23, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 23, 2024
@VihasMakwana
Copy link
Contributor Author

@cmacknz screenshot of error event on Kibana.

Screenshot 2024-07-24 at 3 00 33 PM

@VihasMakwana VihasMakwana enabled auto-merge (squash) July 25, 2024 11:51
@VihasMakwana
Copy link
Contributor Author

@elastic/obs-ds-hosted-services can someone from you team review this?

@VihasMakwana VihasMakwana changed the title [metricbeat][system/process] - Handle non-fatal errors DO NOT MERGE [metricbeat][system/process] - Handle non-fatal errors Jul 25, 2024
Copy link
Contributor

mergify bot commented Jul 26, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b metricbeat-process-multierr upstream/metricbeat-process-multierr
git merge upstream/main
git push upstream metricbeat-process-multierr

@VihasMakwana VihasMakwana marked this pull request as draft July 26, 2024 11:51
@rdner rdner removed their request for review September 10, 2024 07:45
Copy link
Contributor

mergify bot commented Sep 11, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@v1v v1v removed the backport-v8.x label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Elastic Agent] Allow Metricbeat metricsets to report their status to the Elastic Agent
8 participants