Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reviewdog: ignore underscores in package names #4015

Merged
merged 1 commit into from
Apr 13, 2017
Merged

reviewdog: ignore underscores in package names #4015

merged 1 commit into from
Apr 13, 2017

Conversation

7AC
Copy link
Contributor

@7AC 7AC commented Apr 13, 2017

Unfortunately this is the best we can do between golint and reviewdog:

golang/lint#98 (comment)

Unfortunately this is the best we can do between golint and reviewdog:

golang/lint#98 (comment)
@7AC 7AC added the review label Apr 13, 2017
Copy link
Collaborator

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick. WFG

@ruflin ruflin merged commit 4840c93 into elastic:master Apr 13, 2017
@andrewkroh
Copy link
Member

I ran across this the other day and thought it was sort of interesting. https://github.com/kubernetes-incubator/cri-o/blob/master/.tool/lint

@7AC
Copy link
Contributor Author

7AC commented Apr 13, 2017

gometalinter is actually what I run in my editor, and is a superset of golint and other tools IIRC. Doesn't look like reviewdog supports it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants