x-pack/metricbeat/module/sql: Fix bad type handling for sql module #40048
Conversation
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
shmsr
added
the
Team:Service-Integrations
botelastic
bot
removed
the
needs_team
| ret["keyword"] = stringMetrics | ||
| } | ||
|
|
||
| if len(boolMetrics) > 0 { | ||
| ret["bool"] = boolMetrics | ||
| ret["boolean"] = boolMetrics | ||
| } | ||
| if len(dateMetrics) > 0 { | ||
| ret["date"] = dateMetrics | ||
| } | ||
| if len(objectMetrics) > 0 { | ||
| ret["object"] = objectMetrics |
There was a problem hiding this comment.
Decided on these keys from ES docs. Not sure why it was previously "string" and not "keyword" (or "bool" and not "boolean".
Here: https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-types.html
| case float64: | ||
| numericMetrics[k] = v | ||
| switch val := v.(type) { | ||
| case float32, float64, int16, int32, int64, uint32, uint64: |
There was a problem hiding this comment.
Add all those types present in numeric
| case uint: | ||
| return uint64(val) | ||
| case uint32: | ||
| return uint64(val) |
There was a problem hiding this comment.
Did this as uint64 is only supported in numeric. See: https://www.elastic.co/guide/en/elasticsearch/reference/current/number.html
So typecasted uint32 -> uint64
Proposed commit message
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs