Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metricbeat/kubernetes] Remove fallback to the Node's limit for the pod 'usage.limit.pct' metrics #40029

Merged
merged 7 commits into from
Jul 1, 2024
Merged

[metricbeat/kubernetes] Remove fallback to the Node's limit for the pod 'usage.limit.pct' metrics #40029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
220ae6d
Remove fallback to the node limit for the usage.limit.pct metrics cal…
tetianakravchenko Jun 26, 2024
873aebc
remove debug files
tetianakravchenko Jun 26, 2024
dcc356d
fix the fields description
tetianakravchenko Jun 27, 2024
59388cf
Update metricbeat/docs/fields.asciidoc
tetianakravchenko Jul 1, 2024
f32ad29
Update metricbeat/docs/fields.asciidoc
tetianakravchenko Jul 1, 2024
8da750c
Update metricbeat/docs/fields.asciidoc
tetianakravchenko Jul 1, 2024
3916619
update fields description
tetianakravchenko Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ https://github.com/elastic/beats/compare/v8.8.1\...main[Check the HEAD diff]

- Setting period for counter cache for Prometheus remote_write at least to 60sec {pull}38553[38553]
- Add support of Graphite series 1.1.0+ tagging extension for statsd module. {pull}39619[39619]
- Remove fallback to the node limit for the `kubernetes.pod.cpu.usage.limit.pct` and `kubernetes.pod.memory.usage.limit.pct` metrics calculation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that This should me moved under the Breaking Changes section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already under Breaking changes > Metricbeat https://github.com/elastic/beats/blob/873aebc393d753d1ccd9cea9cca141067b368a3a/CHANGELOG.next.asciidoc#breaking-changes
am I missing smth?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this, so maybe it is a rendering issue of the page. I though is only under Metricbeat
Screenshot 2024-06-27 at 4 38 35 PM


*Osquerybeat*

Expand Down
6 changes: 3 additions & 3 deletions metricbeat/docs/fields.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45158,7 +45158,7 @@ format: percent
*`kubernetes.pod.cpu.usage.limit.pct`*::
+
--
CPU usage as a percentage of the defined limit for the pod containers (or total node CPU if one or more containers of the pod are unlimited). If one or more containers of the pod is unlimited and the `node` and `state_node` metricsets are both disabled on that node, this metric will be missing entirely.
CPU usage as a percentage of the defined cpu limits sum of the pod containers. If any container is missing a limit the metric is not emitted.


type: scaled_float
Expand Down Expand Up @@ -45196,7 +45196,7 @@ format: percent
*`kubernetes.pod.memory.usage.limit.pct`*::
+
--
Memory usage as a percentage of the defined limit for the pod containers (or total node allocatable memory if unlimited). If one or more containers of the pod is unlimited and the `node` and `state_node` metricsets are both disabled on that node, this metric will be missing entirely.
Memory usage as a percentage of the defined memory limits sum of the pod containers. If any container is missing a limit the metric is not emitted.


type: scaled_float
Expand Down Expand Up @@ -45234,7 +45234,7 @@ format: bytes
*`kubernetes.pod.memory.working_set.limit.pct`*::
+
--
Working set memory usage as a percentage of the defined limit for the pod containers (or total node allocatable memory if unlimited)
Working set memory usage as a percentage of the defined limits sum of the pod containers. If any container is missing a limit the metric is not emitted.


type: scaled_float
Expand Down
2 changes: 1 addition & 1 deletion metricbeat/module/kubernetes/fields.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading