Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postmigration script cleanup #39915

Merged
merged 6 commits into from
Jul 1, 2024
Merged

Postmigration script cleanup #39915

merged 6 commits into from
Jul 1, 2024

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Jun 17, 2024 •
edited
Loading

Proposed commit message

Removed unused/unnecessary scripts and updated its' usage in other corresponding scripts.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Logs

BK builds: https://buildkite.com/elastic/beats/builds?branch=oakrizan%3Apostmigration-script-cleanup

@oakrizan oakrizan added :Windows ci macOS Enable builds in the CI for darwin testing arm Enable builds in the CI for ARM testing Team:Ingest-EngProd backport-v8.14.0 Automated backport with mergify labels Jun 17, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 17, 2024
@oakrizan oakrizan force-pushed the postmigration-script-cleanup branch from 286c1b3 to bdb6d2f Compare June 17, 2024 09:56
@oakrizan oakrizan added the aws Enable builds in the CI for aws cloud testing label Jun 17, 2024
@oakrizan oakrizan force-pushed the postmigration-script-cleanup branch 3 times, most recently from 7854717 to fd3b7ce Compare June 18, 2024 08:23
@oakrizan oakrizan added :integrations kubernetes Enable builds in the CI for kubernetes labels Jun 18, 2024
@oakrizan oakrizan force-pushed the postmigration-script-cleanup branch from fd3b7ce to 27a7e61 Compare June 26, 2024 13:39
@oakrizan oakrizan marked this pull request as ready for review June 26, 2024 15:52
@oakrizan oakrizan requested a review from a team as a code owner June 26, 2024 15:52
dliappis
dliappis approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

so nice to see all the left over scripts go away! thank you

@oakrizan oakrizan merged commit 351cabb into elastic:main Jul 1, 2024
196 checks passed
mergify bot pushed a commit that referenced this pull request Jul 1, 2024
@oakrizan @mergify
Postmigration script cleanup (#39915)
2f0a403 
Removed unused/unnecessary scripts and updated its' usage in other corresponding scripts

(cherry picked from commit 351cabb)
@mergify mergify bot mentioned this pull request Jul 1, 2024
Merged
6 tasks
oakrizan pushed a commit that referenced this pull request Jul 1, 2024
@mergify
Postmigration script cleanup (#39915) (#40065)
989c6ce 
Removed unused/unnecessary scripts and updated its' usage in other corresponding scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@pazone pazone pazone approved these changes

@alexsapran alexsapran Awaiting requested review from alexsapran

Assignees

@oakrizan oakrizan

Labels
arm Enable builds in the CI for ARM testing aws Enable builds in the CI for aws cloud testing backport-v8.14.0 Automated backport with mergify ci :integrations kubernetes Enable builds in the CI for kubernetes macOS Enable builds in the CI for darwin testing Team:Ingest-EngProd :Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oakrizan @dliappis @pazone