Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updatecli: use GITHUB_ACTOR #39668

Merged
merged 1 commit into from
May 23, 2024
Merged

updatecli: use GITHUB_ACTOR #39668

merged 1 commit into from
May 23, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented May 22, 2024 •
edited
Loading

Proposed commit message

Use GITHUB_ACTOR instead. GIT_USER is not anymore available.

This was caused after merging #39646 since #39472 didn't update the variable.

I tested this feature branch and it worked fine:

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@v1v v1v added the backport-skip Skip notification from the automated backport with mergify label May 22, 2024
@v1v v1v self-assigned this May 22, 2024
@v1v v1v requested a review from a team as a code owner May 22, 2024 13:19
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 22, 2024
@botelastic
Copy link

botelastic bot commented May 22, 2024

This pull request doesn't have a Team:<team> label.

dliappis
dliappis approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v1v v1v merged commit a272326 into main May 23, 2024
10 of 11 checks passed
@v1v v1v deleted the fix/required-variables branch May 23, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees

@v1v v1v

Labels
backport-skip Skip notification from the automated backport with mergify needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v1v @dliappis