Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17](backport #39235) Add MODULE definition for x-pack/dockerlogbeat Go Integration tests #39457

Merged
merged 1 commit into from
May 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 8, 2024

Proposed commit message

In scope of https://github.com/elastic/ingest-dev/issues/3254 - added MODULE env var definition for Go Integration tests to match same behavior as on Jenkins.
Jenkins vs. Buildkite comparison: https://gist.github.com/oakrizan/bf2aa5f1cd1ab01daa1184f471a99abc
BK build: https://buildkite.com/elastic/beats-xpack-dockerlogbeat/builds?branch=elastic%3Amergify%2Fbp%2F7.17%2Fpr-39235

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #39235 done by [Mergify](https://mergify.com).

@mergify mergify bot added the backport label May 8, 2024
@mergify mergify bot requested a review from a team as a code owner May 8, 2024 06:44
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 8, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 8, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-05-09T06:49:36.563+0000

  • Duration: 13 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 8, 2024
@oakrizan
Copy link
Contributor

oakrizan commented May 8, 2024

Validated if steps match steps on Jenkins from 7.17 cc: @dliappis

@oakrizan oakrizan enabled auto-merge (squash) May 8, 2024 13:48
…39235)

* added MODULE env var definition

* removed MODULE setup from common.sh

* updated pipeline and scripts

* pr fixes

* removed pipeline masking where irrelevant

* updated packaging step & gh notif names

(cherry picked from commit b6b4280)
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oakrizan oakrizan merged commit 035fdcd into 7.17 May 9, 2024
100 checks passed
@oakrizan oakrizan deleted the mergify/bp/7.17/pr-39235 branch May 9, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants