Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libbeat/processors/cache: add logging for file read/write #38052

Merged
merged 1 commit into from
Feb 19, 2024
Merged

libbeat/processors/cache: add logging for file read/write #38052

merged 1 commit into from
Feb 19, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Feb 19, 2024

Proposed commit message

See title.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat libbeat backport-skip Skip notification from the automated backport with mergify Team:Security-Service Integrations Security Service Integrations Team 8.13-candidate labels Feb 19, 2024
@efd6 efd6 self-assigned this Feb 19, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 19, 2024
@efd6 efd6 force-pushed the cache_file_logging branch from 55ed4fa to 544feba Compare February 19, 2024 06:39
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 19, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @efd6

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 19, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @efd6

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 19, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @efd6

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 19, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @efd6

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 19, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @efd6

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @efd6

@efd6 efd6 marked this pull request as ready for review February 19, 2024 07:20
@efd6 efd6 requested a review from a team as a code owner February 19, 2024 07:20
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

ShourieG
ShourieG approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming we can ignore the buildkite failures.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 19, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-02-19T20:15:43.464+0000

  • Duration: 33 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 1815
Skipped 46
Total 1861

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6
Copy link
Contributor Author

efd6 commented Feb 19, 2024

/test

2 similar comments
@efd6
Copy link
Contributor Author

efd6 commented Feb 19, 2024

/test

@efd6
Copy link
Contributor Author

efd6 commented Feb 19, 2024

/test

@efd6 efd6 merged commit b9a75c9 into elastic:main Feb 19, 2024
100 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShourieG ShourieG ShourieG approved these changes

Assignees

@efd6 efd6

Labels
8.13-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat libbeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @ShourieG