Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/http_endpoint: add input metrics #36427

Merged
merged 2 commits into from
Sep 12, 2023
Merged

x-pack/filebeat/input/http_endpoint: add input metrics #36427

merged 2 commits into from
Sep 12, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Aug 28, 2023

Proposed commit message

See title.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.11-candidate labels Aug 28, 2023
@efd6 efd6 self-assigned this Aug 28, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 28, 2023
@efd6 efd6 force-pushed the 36402-http_endpoint branch 2 times, most recently from 2b72357 to 6ab4879 Compare August 28, 2023 08:00
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 28, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-12T02:14:04.875+0000

  • Duration: 74 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 3177
Skipped 174
Total 3351

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 force-pushed the 36402-http_endpoint branch from 6ab4879 to e2bfa3c Compare August 28, 2023 09:32
@efd6 efd6 marked this pull request as ready for review August 28, 2023 10:53
@efd6 efd6 requested a review from a team as a code owner August 28, 2023 10:53
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 force-pushed the 36402-http_endpoint branch from e2bfa3c to 7febad2 Compare August 28, 2023 20:37
@mergify

This comment was marked as outdated.

Sign in to view
@efd6 efd6 force-pushed the 36402-http_endpoint branch from 7febad2 to 5d23b56 Compare September 4, 2023 21:06
@mergify

This comment was marked as outdated.

Sign in to view
@efd6 efd6 force-pushed the 36402-http_endpoint branch from 5d23b56 to 38aacfe Compare September 5, 2023 09:35
@mergify

This comment was marked as outdated.

Sign in to view
@efd6 efd6 force-pushed the 36402-http_endpoint branch from 38aacfe to 19b7921 Compare September 5, 2023 22:58
@mergify

This comment was marked as outdated.

Sign in to view
@efd6 efd6 force-pushed the 36402-http_endpoint branch from 19b7921 to efcfc0b Compare September 7, 2023 07:39
@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 36402-http_endpoint upstream/36402-http_endpoint
git merge upstream/main
git push upstream 36402-http_endpoint

@efd6 efd6 force-pushed the 36402-http_endpoint branch from efcfc0b to 7245d0d Compare September 11, 2023 20:53
andrewkroh
andrewkroh reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the choice of metrics. Those should be useful diagnostic data.

x-pack/filebeat/input/http_endpoint/input.go Outdated
log := ctx.Logger.With("address", e.addr)
pattern := e.config.URL

var err error
metrics.bindAddr.Set(e.addr)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to come from the server. For example if through config I asked it to bind to (127.0.0.1:0) then the input metric should show the actual ephemeral port that it landed on.

@efd6 efd6 requested a review from andrewkroh September 12, 2023 02:13
@efd6 efd6 merged commit c5c7980 into elastic:main Sep 12, 2023
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@efd6 @Scholar-Li
x-pack/filebeat/input/http_endpoint: add input metrics (elastic#36427)
3cb5cdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@efd6 efd6

Labels
8.11-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filebeat/inputs/http_endpoint - Add input metrics
3 participants
@efd6 @elasticmachine @andrewkroh